This repository was archived by the owner on Dec 11, 2025. It is now read-only.
(deno) TSV type check overhaul.#1987
Merged
effigies merged 7 commits intobids-standard:masterfrom Jun 7, 2024
Merged
Conversation
…ified in sidecar and schema rules for that column are in the 'json schema' defined style outlined in bids-standard/bids-specification#1838
… schema/enhanceTSVTypeCheck
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1987 +/- ##
=======================================
Coverage 85.68% 85.68%
=======================================
Files 91 91
Lines 3792 3792
Branches 1220 1220
=======================================
Hits 3249 3249
Misses 457 457
Partials 86 86 ☔ View full report in Codecov by Sentry. |
effigies
reviewed
Jun 7, 2024
Collaborator
|
Fixed the CI failures. Back to green on Ubuntu! |
…validator into schema/enhanceTSVTypeCheck
effigies
reviewed
Jun 7, 2024
Collaborator
effigies
left a comment
There was a problem hiding this comment.
I think I read through all the real changes.
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
effigies
approved these changes
Jun 7, 2024
effigies
referenced
this pull request
in bids-standard/bids-examples
Jun 7, 2024
As of https://github.com/bids-standard/bids-validator/pull/1987, these should no longer raise errors.
effigies
referenced
this pull request
in bids-standard/bids-examples
Jun 7, 2024
As of https://github.com/bids-standard/bids-validator/pull/1987, these should no longer raise errors.
This was referenced Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify tsv column value type checks to use user defined types if specifiedified in sidecar and schema rules for that column are in the 'json schema' defined style outlined in bids-standard/bids-specification#1838
For traditional schema defined columns, if they're required the type check produces an error, but if it is not required it generates a warning.
I ran
deno fmton the files and its got opinions on quotes and semicolons, thats where most the changes come from.