run node tests in github actions by rwblair · Pull Request #1375 · bids-standard/legacy-validator

rwblair · 2021-10-26T19:12:54Z

See if it gets same problem as in #1358

…ss.cwd

This reverts commit 3e0a391.

…on process.cwd" This reverts commit 77f1cea.

rwblair · 2021-10-26T20:29:30Z

I'm still clueless as to why fs.existsSync returns false in gitlab, circleci, and githubactions but true when in a proper shell. Maybe worth testing for existeance some other way and catching ENOENT code.

… ci/github_actions

This reverts commit 0a48622.

This reverts commit 56614cd.

codecov · 2022-01-07T19:50:17Z

Codecov Report

Merging #1375 (e84bdb0) into master (26a3a57) will decrease coverage by 0.12%.
The diff coverage is 58.76%.

❗ Current head e84bdb0 differs from pull request most recent head e5e9250. Consider uploading reports for the commit e5e9250 to get more accurate results

@@            Coverage Diff             @@
##           master    #1375      +/-   ##
==========================================
- Coverage   84.15%   84.03%   -0.13%     
==========================================
  Files          90       90              
  Lines        3642     3652      +10     
  Branches     1101     1108       +7     
==========================================
+ Hits         3065     3069       +4     
- Misses        483      489       +6     
  Partials       94       94

Impacted Files	Coverage Δ
bids-validator/utils/files/readDir.js	`78.34% <0.00%> (ø)`
bids-validator/validators/bids/fullTest.js	`95.69% <ø> (ø)`
bids-validator/validators/json/json.js	`99.11% <ø> (ø)`
...lidator/validators/microscopy/checkJSONAndField.js	`97.14% <ø> (ø)`
...ds-validator/validators/microscopy/checkSamples.js	`100.00% <ø> (ø)`
...validator/validators/tsv/validateContRecordings.js	`100.00% <ø> (ø)`
...ids-validator/validators/tsv/validateTsvColumns.js	`52.56% <30.76%> (-1.08%)`	⬇️
bids-validator/utils/issues/index.js	`79.54% <50.00%> (-0.69%)`	⬇️
bids-validator/validators/microscopy/ometiff.js	`72.97% <90.00%> (-0.64%)`	⬇️
bids-validator/cli.js	`81.08% <100.00%> (ø)`
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26a3a57...e5e9250. Read the comment docs.

effigies · 2022-01-07T20:54:41Z

will --colors work for windows gitlab?

LOLNO

This reverts commit 24150f4.

…play nicer with windows.

effigies · 2022-01-07T21:17:18Z

@rwblair Assume you've seen https://stackoverflow.com/questions/66185466/npm-script-fails-is-not-recognized-as-an-internal-or-external-command? It's not obvious that there are useful suggestions there, but it does seem that for some reason we're generating unix test scripts when we should be generating Windows.

…w it to play nicer with windows." This reverts commit 93bcebb.

rwblair · 2022-01-07T21:39:46Z

@effigies thank you. Made me wonder why things in the package.json were calling bins with relative paths. Turns out to be for no good reason. Now its failing for new reasons.

Also looks like eslint on ubuntu might not really be running. The command takes a minute on my local machine, but is done in seconds on ci.

…IsMicroscopy called by IsBids in type.js

…sbuild-runner

…eing wonky.

* first try * add functional DatasetLinks schema: any str bigger than len 0 --> uri * add tests * fix lint * use propertyNames feature, instead of not feature * migrated eeg_matchingpennies from GitHub to GIN * fix formatting E501 * Update bids-validator/tests/json.spec.js Co-authored-by: Chris Markiewicz <effigies@gmail.com> * Update bids-validator/validators/json/schemas/dataset_description.json * fix tests Co-authored-by: Chris Markiewicz <effigies@gmail.com>

…ity blacklist check before full summary, so we can error out on blacklisted modalities in bidsignore, and still have an accurate summary of non bidsignored files

Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.25 to 3.3.0. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.1.25...3.3.0) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

… npm8.

effigies · 2022-03-16T13:58:31Z

This looks good. Cleaned up in #1426 with one additional commit.

rwblair added 8 commits October 26, 2021 14:12

run node tests in github actions

97e046d

fix yml syntax error

0470055

fix yml syntax error

9c4a1a7

use node action to actually setup node

3bcc8be

try __dirname based join to find testdata instead of relying on proce…

77f1cea

…ss.cwd

shut eslint up

3e0a391

Revert "shut eslint up"

677c9f9

This reverts commit 3e0a391.

Revert "try __dirname based join to find testdata instead of relying …

21fde2d

…on process.cwd" This reverts commit 77f1cea.

rwblair added 4 commits January 7, 2022 13:21

Merge branch 'master' of github.com:bids-standard/bids-validator into…

3792f1f

… ci/github_actions

add --colors to jest call

0a48622

Revert "add --colors to jest call"

56614cd

This reverts commit 0a48622.

Revert "Revert "add --colors to jest call""

50a11d9

This reverts commit 56614cd.

will --colors work for windows gitlab?

24150f4

rwblair added 2 commits January 7, 2022 14:56

Revert "will --colors work for windows gitlab?"

59a93d8

This reverts commit 24150f4.

putting command after ./ in package.json lint call might allow it to …

93bcebb

…play nicer with windows.

rwblair added 2 commits January 7, 2022 15:25

Revert "putting command after ./ in package.json lint call might allo…

b512edc

…w it to play nicer with windows." This reverts commit 93bcebb.

remove relative paths from npm scripts

703f336

rwblair and others added 8 commits January 7, 2022 15:56

add eslint ignore and update eslint call to use config file

a8add55

eslint/prettier fixes

bb83792

move eslintrc to root of project

0d67e6a

set no auto clrf for git/actions to fix failing windows test

d1d6ad8

add missing lf..

5ca5d73

Added the microscopy Regex parts in the rules and added the function …

e7bd0df

…IsMicroscopy called by IsBids in type.js

Added the different microscopy modality suffixes

a8d5eca

Add back the enter removed by accident in phenotypic_rules.json

c3ff2fb

rwblair and others added 25 commits March 15, 2022 14:36

updated package-lock to reflect package.json changes.

a0e2e31

have microscopy json check return empty list if no other issues found

c725d7c

set esbuild buffer size env in bin/bids-validator when we are using e…

8f4663c

…sbuild-runner

added babel runtime to web package.json, maybe it was just my setup b…

b4c8972

…eing wonky.

Fix NO_AUTHORS evidence zero length array passing array type as evidence

cd627bb

add option to throw an error if specified modalities are detected

47a3bcd

eslint --fix

e0f2f92

update consoleFormat spec to not check for undefined file in output.

7ad713a

treat ignored files in node readDir like we do in browser. Call modal…

a8e582e

…ity blacklist check before full summary, so we can error out on blacklisted modalities in bidsignore, and still have an accurate summary of non bidsignored files

revert changes to gitTree ignore check in readDir.js

cf26b68

v1.9.0

b48b1ab

v1.9.1-dev.0

c828499

add prepublish step to root package.json

f804f49

switch prepublish scripts to prepublishOnly, prepublish deprectaed in…

c07b264

… npm8.

v1.9.1

2a9d30f

v1.9.2

c1aa9f6

v1.9.3-dev.0

87c2402

remove relative paths from npm scripts

98917df

fix errant import from rebase?

1e9936b

Merge remote-tracking branch 'origin/master' into ci/github_actions

1f08ad9

fix lint issues. fix call to linter for linux in package.json

0b43f96

porperty -> property

b83c04d

does windows actually care about single vs double quotes?

e5e9250

effigies mentioned this pull request Mar 16, 2022

CI: Run Node tests in GitHub actions #1426

Merged

rwblair closed this Mar 16, 2022

rwblair deleted the ci/github_actions branch March 16, 2022 14:15

yarikoptic mentioned this pull request Oct 16, 2024

[ENH] microelectrode electrophysiology specification (BEP032) bids-standard/bids-specification#1705

Closed

22 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

run node tests in github actions#1375

run node tests in github actions#1375
rwblair wants to merge 103 commits intomasterfrom
ci/github_actions

rwblair commented Oct 26, 2021

Uh oh!

rwblair commented Oct 26, 2021

Uh oh!

codecov bot commented Jan 7, 2022 •

edited

Loading

Uh oh!

effigies commented Jan 7, 2022

Uh oh!

effigies commented Jan 7, 2022

Uh oh!

rwblair commented Jan 7, 2022

Uh oh!

effigies commented Mar 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

rwblair commented Oct 26, 2021

Uh oh!

rwblair commented Oct 26, 2021

Uh oh!

codecov bot commented Jan 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

effigies commented Jan 7, 2022

Uh oh!

effigies commented Jan 7, 2022

Uh oh!

rwblair commented Jan 7, 2022

Uh oh!

effigies commented Mar 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Jan 7, 2022 •

edited

Loading