Skip to content

BEP update#88

Merged
sappelhoff merged 4 commits intobids-standard:gh-pagesfrom
franklin-feingold:enh/bep
Jan 29, 2020
Merged

BEP update#88
sappelhoff merged 4 commits intobids-standard:gh-pagesfrom
franklin-feingold:enh/bep

Conversation

@franklin-feingold
Copy link
Copy Markdown
Collaborator

@franklin-feingold franklin-feingold commented Jan 23, 2020

I have updated the BEPs for those I heard back from. I added a new section for BEPs that become tools rather than merged into the main spec. I think there will be some more BEPs that may fit into this category in the future

addresses: #80

Copy link
Copy Markdown
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we could make the diff of tables more readable.

@franklin-feingold - I suppose you have the updates in some google sheet and then you just go ahead, paste them in, and adjust the markdown table borders?

If this is your workflow, it might be nicer for the reviewers to just see the google sheet. :-)


All of the extension ideas that are not backwards compatible and thus
will have to wait for BIDS 2.0 are listed
[here](https://docs.google.com/document/d/1LEgsMiisGDe1Gv-hBp1EcLmoz7AlKj6VYULUgDD3Zdw).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move this sentence about BIDS 2.0 up to the top:

You can also contribute to ongoing BIDS Extension Proposals. Below is a
table of currently-active BEPs. The "Extension label" column provides a
direct link to the documentation.

Note that all extension ideas that are not backwards compatible and thus
will have to wait for BIDS 2.0 are listed
[here](https://docs.google.com/document/d/1LEgsMiisGDe1Gv-hBp1EcLmoz7AlKj6VYULUgDD3Zdw)
instead.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps to keep this focused on the BEP update may you please open a new PR with this proposal?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll do that once this PR is merged. Before we can merge it, can you answer my comment in #88 (review) ?

--> it'd perhaps make the review easier :-)

Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
@robertoostenveld robertoostenveld self-requested a review January 29, 2020 08:12
Copy link
Copy Markdown
Collaborator

@robertoostenveld robertoostenveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked the rendering of the table (looks good) and all links (they all work fine).

Copy link
Copy Markdown
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not check the content itself but I am in touch with Franklin to make this easier in the future.

@sappelhoff sappelhoff merged commit 7b0fabf into bids-standard:gh-pages Jan 29, 2020
@sappelhoff
Copy link
Copy Markdown
Member

thanks for the PR @franklin-feingold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants