add twitter badge#49
Merged
franklin-feingold merged 6 commits intobids-standard:gh-pagesfrom Jul 16, 2019
Merged
Conversation
3 tasks
sappelhoff
reviewed
Jul 12, 2019
Member
sappelhoff
left a comment
There was a problem hiding this comment.
Thanks! Did you test how it looks locally / on your fork? Could you perhaps post a link of the rendering?
rwblair
approved these changes
Jul 12, 2019
Collaborator
Author
|
here is the rendeirng - https://franklin-feingold.github.io/BIDS/ |
sappelhoff
requested changes
Jul 13, 2019
Member
sappelhoff
left a comment
There was a problem hiding this comment.
Okay, thanks for the rendering!
I made a couple of comments.
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
sappelhoff
approved these changes
Jul 16, 2019
Member
sappelhoff
left a comment
There was a problem hiding this comment.
Yes, the most recent suggestions look good to me. I cannot commit them, because I don't seem to have the necessary rights:
re: browser extensions --> yes, I probably had the badge blocked then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses point 3 of bids-standard/bids-specification#266