Add Logo and Favicon to webpage#47
Merged
franklin-feingold merged 29 commits intobids-standard:gh-pagesfrom Jun 20, 2019
Merged
Add Logo and Favicon to webpage#47franklin-feingold merged 29 commits intobids-standard:gh-pagesfrom
franklin-feingold merged 29 commits intobids-standard:gh-pagesfrom
Conversation
sappelhoff
reviewed
Jun 20, 2019
Member
sappelhoff
left a comment
There was a problem hiding this comment.
Why do we need so many different favicons?
Collaborator
Author
|
this is to account for the different ways one can access the site and make sure they have the favicon for all types |
Member
|
Need is a strong word, but the favicon conversion site gave them to us so I guess we can use them. We can probably get away with just 16x16, 32x32, and 96x96. |
rwblair
approved these changes
Jun 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered result: https://franklin-feingold.github.io/BIDS/
The favicon does not appear on the rendered, but I wonder if it will appear once merged. I used - https://www.favicon-generator.org/ - to generate the code and folder of files to create the favicon