Add fallback to trackOutboundLink#42
Merged
chrisgorgo merged 1 commit intobids-standard:gh-pagesfrom Feb 14, 2019
Merged
Conversation
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External links from https://bids.neuroimaging.io (e.g. to the starter kit) are not active if the Google Tag Manager code cannot be loaded. Following the guidelines at https://hacks.mozilla.org/2016/01/google-analytics-privacy-and-event-tracking/ this commit adds a fallback to the trackOutboundLink function allowing tracked links to be followed in the event that the gtag object is not available e.g. due to network errors or client tracking protection.
TODO: confirm that tracking still functions with the fallback in place.