Skip to content

Embedded google group#26

Merged
chrisgorgo merged 4 commits intobids-standard:gh-pagesfrom
franklin-feingold:gh-pages
Aug 10, 2018
Merged

Embedded google group#26
chrisgorgo merged 4 commits intobids-standard:gh-pagesfrom
franklin-feingold:gh-pages

Conversation

@franklin-feingold
Copy link
Copy Markdown
Collaborator

Embedded the google group
Added a space between the bids contributor guide hyperlink and 'Please adhere to our Code of Conduct'

Between the hyperlinked BIDS Contributor Guide and 'Please adhere ...'
@chrisgorgo
Copy link
Copy Markdown

The mailing list embedding does not render when I open index.html file locally. How did you tested it?

@franklin-feingold
Copy link
Copy Markdown
Collaborator Author

Unfortunately the frame will not render the google group locally. The url embedded in the iframe had a parameter called 'parenturl'. The parenturl has to match the domain that the document with the iframe is being served from. When tested locally the url for local files on our computers is weird and the browsers didn't like it when they cross checked the origin I believe.
For testing, I opened it from my github repo (https://franklin-feingold.github.io/BIDS/). From there I saw that the webpage displays the embedded google group.

@chrisgorgo
Copy link
Copy Markdown

Thanks!

image
could you fix the styling?

spacing between the embedded google group and 'Want to extend...' and the hyperlinked BIDS Contributor Guide and 'Please adhere ...'
@franklin-feingold
Copy link
Copy Markdown
Collaborator Author

I added a white background fill behind the embedded google group to improve the contrast. It looks better and can see the different posts more clearly.

bids_google_group_white_background

@chrisgorgo
Copy link
Copy Markdown

Awesome! Thanks!

@chrisgorgo chrisgorgo merged commit 94e4dc0 into bids-standard:gh-pages Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants