Skip to content

[ENH] Steering Group meeting shareables#102

Merged
sappelhoff merged 8 commits intobids-standard:gh-pagesfrom
franklin-feingold:SG_meet1
Mar 17, 2020
Merged

[ENH] Steering Group meeting shareables#102
sappelhoff merged 8 commits intobids-standard:gh-pagesfrom
franklin-feingold:SG_meet1

Conversation

@franklin-feingold
Copy link
Copy Markdown
Collaborator

This PR is adding a post to our website to share the Steering Groups: executive summary, action items, and minutes from a previous meeting

updated BEPs that have responded by 1/16 7p PST. also added a new column for communication channels
@franklin-feingold franklin-feingold requested review from KirstieJane, robertoostenveld, rwblair and sappelhoff and removed request for rwblair March 12, 2020 22:18
Copy link
Copy Markdown
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this @franklin-feingold . I understand that this is intended to be a bit informal, and I like it --> still I added some points to help you make the document more readable to everybody.

I didn't get the "minutes" section --> aren't all these points already mentioned above?

@sappelhoff
Copy link
Copy Markdown
Member

PS: When making PRs, you can save yourself a lot of trouble by using this workflow:

  1. bring your forked (franklin-feingold) master completely up to date with the upstream (bids-standard) master
  2. only THEN make a branch from your forked master
  3. work and then submit PR

That will keep the commit history cleaner (1 sensible commit instead of 5 confusing ones) and save you some work.

@franklin-feingold franklin-feingold changed the title Steering Group meeting shareables [ENH] Steering Group meeting shareables Mar 13, 2020
@franklin-feingold
Copy link
Copy Markdown
Collaborator Author

@sappelhoff incorporated your comments

This PR has a few more commits because of previous branch conflicts and remedying.

@sappelhoff
Copy link
Copy Markdown
Member

This PR has a few more commits because of previous branch conflicts and remedying.

A good way for "resolving" all conflicts prior to making a fresh branch is:

  • git reset --hard upstream/master (assuming that upstream is the name of the remote that you added through git remote add upstream https://github.com/bids-standard/bids-specification

This will force your forked master to align with the upstream master ... and then you can branch off with a clean history.

Copy link
Copy Markdown
Collaborator

@robertoostenveld robertoostenveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @sappelhoff that more links would be useful.

Copy link
Copy Markdown
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making some adjustments! I added some final points.

Lastly: If we want to keep the "minutes" section, can you please design it as an unordered list?

  • I think it makes more sense
    • that way ...
    • with thoughts being separated
  • on different levels
  • (note: this is a bad example, but I hope you get my point 🤣 )

We discussed the channels through which to share updates to the BIDS specification.
An issue was opened to start crowdsourcing and collecting this information.
We will be using this to share the release of v1.2.2 and to request the final rounds of feedback on the Genetic information extension.
[An issue](https://github.com/bids-standard/bids-specification/issues/415) was opened to start crowdsourcing and collecting this information.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[An issue](https://github.com/bids-standard/bids-specification/issues/415) was opened to start crowdsourcing and collecting this information.
A [GitHub issue](https://github.com/bids-standard/bids-specification/issues/415) was opened to start crowdsourcing and collecting this information.

An issue was opened to start crowdsourcing and collecting this information.
We will be using this to share the release of v1.2.2 and to request the final rounds of feedback on the Genetic information extension.
[An issue](https://github.com/bids-standard/bids-specification/issues/415) was opened to start crowdsourcing and collecting this information.
We will be using this list of channels to share the release of v1.2.2 and to request the final rounds of feedback on the Genetic information extension.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We will be using this list of channels to share the release of v1.2.2 and to request the final rounds of feedback on the Genetic information extension.
We will be using the resulting list of communication channels to share the release of v1.2.2 and to request the final rounds of feedback on the Genetic information extension ([BEP018](https://docs.google.com/document/d/1uRkgyzESLKuGjXi98Z97Wh6vt-iLN5nOAb9TG16CjUs/)).


We discussed considerations for when to open a repository under the BIDS standard organization on GitHub.
There should be multiple people committed to the repository (otherwise it is better of under the personal GitHub account), the maintainers should be clearly identifiable (e.g. as a CODEOWNERS file at top level), there should be a code of conduct in the repo that is consistent with that of the BIDS specification, and (as a consequence of the code of conduct) the repository should welcome contributions from others.
Previously, community members have opened repositories under our BIDS standard organization.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Previously, community members have opened repositories under our BIDS standard organization.
Previously, community members have opened repositories under the BIDS [GitHub organization](https://help.github.com/en/github/setting-up-and-managing-organizations-and-teams/about-organizations) named [`bids-standard`](https://github.com/bids-standard/).

There should be multiple people committed to the repository (otherwise it is better of under the personal GitHub account), the maintainers should be clearly identifiable (e.g. as a CODEOWNERS file at top level), there should be a code of conduct in the repo that is consistent with that of the BIDS specification, and (as a consequence of the code of conduct) the repository should welcome contributions from others.
Previously, community members have opened repositories under our BIDS standard organization.
We want to codify guidelines to govern this.
The plan is that there should be multiple people committed to the repository (otherwise it is better of under the personal GitHub account), the maintainers should be clearly identifiable (e.g. as a CODEOWNERS file at top level), there should be a code of conduct in the repo that is consistent with that of the BIDS specification, and (as a consequence of the code of conduct) the repository should welcome contributions from others.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The plan is that there should be multiple people committed to the repository (otherwise it is better of under the personal GitHub account), the maintainers should be clearly identifiable (e.g. as a CODEOWNERS file at top level), there should be a code of conduct in the repo that is consistent with that of the BIDS specification, and (as a consequence of the code of conduct) the repository should welcome contributions from others.
The plan is that there should be multiple people committed to the repository (otherwise it is better of under the personal GitHub account), the maintainers should be clearly identifiable (e.g., as a [CODEOWNERS file](https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners) at top level), there should be a code of conduct in the repo that is consistent with that of the BIDS specification, and (as a consequence of the code of conduct) the repository should welcome contributions from others.

We want to host another [Community Forum](https://bids.neuroimaging.io/2020/01/02/announcement-community-forum-events.html) (but not too frequent) and potentially a starter kit/demo in the Open Science Room at OHBM.

Regarding issue [#407](https://github.com/bids-standard/bids-specification/pull/407), we consider Zenodo to be a suitable the location to store historical specification pdfs, also for future versions.
Regarding discussions on where to host our historical specification pdfs (please refer to issue [#407](https://github.com/bids-standard/bids-specification/pull/407)), we consider Zenodo to be a suitable the location to store our specification pdfs.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Regarding discussions on where to host our historical specification pdfs (please refer to issue [#407](https://github.com/bids-standard/bids-specification/pull/407)), we consider Zenodo to be a suitable the location to store our specification pdfs.
Regarding discussions on where to host our historical specification pdfs (please refer to issue [#407](https://github.com/bids-standard/bids-specification/pull/407)), we consider Zenodo to be a suitable location to store our specification pdfs.

@franklin-feingold
Copy link
Copy Markdown
Collaborator Author

franklin-feingold commented Mar 16, 2020

@robertoostenveld @sappelhoff - thank you for the feedback - have applied your thoughts

Re: minutes, I kept the top-level discussion with bullet points to show the different subtopics (and subsubtopics) hit during that conversation. I think this makes it easier to follow and interpret the conversation

@sappelhoff sappelhoff merged commit a68ab40 into bids-standard:gh-pages Mar 17, 2020
@sappelhoff
Copy link
Copy Markdown
Member

Thanks @franklin-feingold

@franklin-feingold franklin-feingold deleted the SG_meet1 branch March 20, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants