[INFRA] Relax line length limit for linting YAML files#673
Merged
effigies merged 3 commits intobids-standard:masterfrom Nov 17, 2020
Merged
[INFRA] Relax line length limit for linting YAML files#673effigies merged 3 commits intobids-standard:masterfrom
effigies merged 3 commits intobids-standard:masterfrom
Conversation
306b017 to
3aaa61d
Compare
Also bump Python version and cache pip
3aaa61d to
633b7d3
Compare
sappelhoff
approved these changes
Nov 17, 2020
tsalo
approved these changes
Nov 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
80 characters seems unnecessarily constrained. 99 characters + '\n' is generally a good rule to fit on a single line for default configurations of terminals on OSX and Linux. I assume Windows users are not often burdened by strict TTY emulation.
This is intended to avoid unnecessary rounds of review when adding entities as people break lines at reasonable places and get yelled at by the linter.
Also adding a
.gitignorein tools.