Skip to content

[ENH] Clarify phenotypic and assessment data in new section#331

Merged
sappelhoff merged 3 commits intobids-standard:masterfrom
sappelhoff:pheno
Sep 23, 2019
Merged

[ENH] Clarify phenotypic and assessment data in new section#331
sappelhoff merged 3 commits intobids-standard:masterfrom
sappelhoff:pheno

Conversation

@sappelhoff
Copy link
Copy Markdown
Member

closes #280

  • make "phenotype" data its own section instead of a subsection of "participants"
  • clarify WHERE to place the file, and how to name them
  • be more consistent with using MUST, SHOULD, ...

sappelhoff and others added 2 commits September 14, 2019 16:36
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Copy link
Copy Markdown
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Anybody else? @bids-standard/raw

@effigies effigies changed the title [FIX] make phenotype data its own section and clarify usage [ENH] Clarify phenotypic and assessment data in new section Sep 18, 2019
Copy link
Copy Markdown
Collaborator

@teonbrooks teonbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@robertoostenveld
Copy link
Copy Markdown
Collaborator

LGTM.

Anybody else? @bids-standard/raw

looks good to me.

@sappelhoff sappelhoff merged commit 4c430f3 into bids-standard:master Sep 23, 2019
@sappelhoff sappelhoff deleted the pheno branch September 23, 2019 10:12
@sappelhoff
Copy link
Copy Markdown
Member Author

thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Examples for use of "phenotype" saving survey data in BIDS

4 participants