[FIX] Revise template-generated coordinate systems#307
Merged
effigies merged 3 commits intobids-standard:common-derivativesfrom Dec 5, 2019
Merged
Conversation
This PR supersedes bids-standard#213, and should be rebased with master after bids-standard#306 is merged. W.r.t. master it only adds the table of _Nonstandard template identifiers_ W.r.t. `common-derivatives`, the changes are: - [x] Removed the distinction between surface templates and volumetric templates. After all, to properly apply a surface template one should first spatially normalize to a particular volumetric template. Although it is possible to create mixed templates (e.g. using ``MNI152Lin`` to generate a mapping for volumetric coordinates and then, say, ``fsLR`` for the surface after some surface mapping process), this option should be discouraged. Anyways, this discussion does not affect how the names of BIDS entities should be specified, since one can always describe how the template coordinates are generated with the information described in this PR. - [x] Removed ``MNI152NLin6AsymConte69`` because it does not define any new coordinate system (see bids-standard#207 (comment)), - [x] Removed ``FS305`` as it is now covered by ``fsaverage``. - [x] Reorganized subsections in "standard" vs "nonstandard" spaces.
8 tasks
…stem - [x] Describes more clearly the situation when files do not have ``space-`` definition. - [x] Remove the ``ReferenceIndex`` as an index does not generate a coordinate system (the concept here is mixed up with that of image registration, which is just a process).
9b11bd3 to
4f714f4
Compare
5 tasks
6 tasks
1a7d012 to
c200cff
Compare
…emplate-coordinates-2
Collaborator
Collaborator
|
Squashed to avoid a tangle of merge commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supersedes #213, and should be rebased with master after #306 is
merged.
W.r.t.
masterit only adds the table of Nonstandard templateidentifiers
W.r.t.
common-derivatives, the changes are:templates. After all, to properly apply a surface template one
should first spatially normalize to a particular volumetric
template. Although it is possible to create mixed templates
(e.g. using
MNI152Linto generate a mapping for volumetriccoordinates and then, say,
fsLRfor the surface after somesurface mapping process), this option should be discouraged.
Anyways, this discussion does not affect how the names of BIDS
entities should be specified, since one can always describe how
the template coordinates are generated with the information
described in this PR.
MNI152NLin6AsymConte69because it does not defineany new coordinate system (see
[ENH] Derived (processed) MR data #207 (comment)),
FS305as it is now covered byfsaverage.