BEP032: Relax many levels to optional#2363
Merged
CodyCBakerPhD merged 2 commits intobep032-reviewfrom Mar 17, 2026
Merged
Conversation
bendichter
approved these changes
Mar 16, 2026
Contributor
bendichter
left a comment
There was a problem hiding this comment.
looks good, thanks for these changes @CodyCBakerPhD !
ree-gupta
reviewed
Mar 17, 2026
Member
ree-gupta
left a comment
There was a problem hiding this comment.
The downgrades look good to me. I would additionally also vote to make sampling_frequency per channel recommended or even required.
There is a required SamplingFrequency key in the JSON as of now.
Co-authored-by: Reema Gupta <59512969+ree-gupta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ree-gupta @bendichter These are my suggestions for what can/should be relaxed in terms of 'how easy' things are to extract from NWB
Note that for many of these fields, there might be a generic place in NWB to write some information but it is nearly always free-text strings that cannot be reliably parsed into individual BIDS fields. A fully automated conversion tool could not set those fields, but an interactive agent such as the meditor could likely parse the text and provide guesses to matching fields, so I would suggest that being a post-organization enhancement for data contributors
An extension or core modification would be needed to completely 'harmonize' the two (not that I am convinced that would entirely be worth it, given we can just treat the BIDS metadata as a ground truth)
cc @rwblair @effigies