fix: Address warnings, error on malformed TSV contents#2240
Merged
effigies merged 4 commits intobids-standard:maint/1.10.1from Oct 30, 2025
Merged
fix: Address warnings, error on malformed TSV contents#2240effigies merged 4 commits intobids-standard:maint/1.10.1from
effigies merged 4 commits intobids-standard:maint/1.10.1from
Conversation
938969e to
3e01f2c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2240 +/- ##
==========================================
- Coverage 82.85% 82.79% -0.06%
==========================================
Files 20 20
Lines 1621 1639 +18
==========================================
+ Hits 1343 1357 +14
- Misses 278 282 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3e01f2c to
963531d
Compare
963531d to
69db614
Compare
yarikoptic
reviewed
Oct 30, 2025
yarikoptic
reviewed
Oct 30, 2025
69db614 to
42223a0
Compare
yarikoptic
approved these changes
Oct 30, 2025
Collaborator
yarikoptic
left a comment
There was a problem hiding this comment.
Thank you @effigies . I test driven it (both context handler and decorator versions) and have not see warnings popping up any longer -- life will be so much better now!!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2010 following pattern used in bids-standard/pybids#1136.
Closes #2238.