Add a few more tests for the schema#1963
Merged
effigies merged 1 commit intobids-standard:masterfrom Nov 1, 2024
Merged
Conversation
- "explicit better than implicit" especially in case of tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1963 +/- ##
=======================================
Coverage 86.87% 86.87%
=======================================
Files 16 16
Lines 1410 1410
=======================================
Hits 1225 1225
Misses 185 185 ☔ View full report in Codecov by Sentry. |
17 tasks
Collaborator
Author
effigies
reviewed
Oct 28, 2024
Comment on lines
+98
to
+99
| else: | ||
| raise AssertionError(f"Object type {object_type} not implemented.") |
Collaborator
There was a problem hiding this comment.
This makes more sense to me to put up right under for object_type in schema_obj.objects: rather than checking repeatedly.
Collaborator
Author
There was a problem hiding this comment.
if it more of defensive coding to close up if/elif chain to not leave it "untested" -- code should never run into it (it is exception)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when test fails - very hard to debug. hopefully more of checks would help