also, I believe that according to our new rules as listed in DECISION-MAKING, you have to add yourself to this file: https://github.com/bids-standard/bids-specification/blob/master/CODEOWNERS

Finally, after this PR is merged, you can make a new PR adding yourself as a contributor to BIDS in this file: https://github.com/bids-standard/bids-specification/blob/master/src/99-appendices/01-contributors.md

Sorry if that seems like a lot of overhead for the tiny changes. But perhaps you can see it as an opportunity and entry point for future contributions instead :-)

My reading of the rules was that adding yourself to 01-contributors.md and CODEOWNERS is optional, but if one chooses to they need to add their name to both (not just 01-contributors.md). Maybe we need to clarify this language.

Ok, I'm lost :). Do I have to add myself as a contributor to have my request accepted? Or could it be accepted anyway?

I just re-read the DECISION-MAKING.md file and yes - adding oneself as a contributor is optional ... but if one decides to do that, one also needs to add oneself as a CODEOWNER.

for the present issue: @JegouA it would be completely fine for you to incorporate my feedback and then we can merge this PR in a few days (if at least one more BIDS person agrees that this is helpful)

@JegouA do you see the two suggestions I made to your code? If you accept them, we are ready to merge this.

I suggest to use BrainVision Core Data Format, because it corresponds with Brain Products website: https://www.brainproducts.com/productdetails.php?id=21&tab=5

PS: They have updated their examples, and there is no mention of .dat anymore :-)

Thanks!

Please feel free to make a new Pull Request to add yourself as a contributor (if you want)!

That is, you can add your name here: 01-contributors.md

@sappelhoff sorry, I didn't know that I have to accept the changes