SCHEMA: Add convenience objects to nifti_header context#1406
Merged
effigies merged 1 commit intobids-standard:masterfrom Feb 16, 2023
Merged
SCHEMA: Add convenience objects to nifti_header context#1406effigies merged 1 commit intobids-standard:masterfrom
effigies merged 1 commit intobids-standard:masterfrom
Conversation
Codecov ReportBase: 88.65% // Head: 88.65% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1406 +/- ##
=======================================
Coverage 88.65% 88.65%
=======================================
Files 11 11
Lines 1084 1084
=======================================
Hits 961 961
Misses 123 123 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
e19b0f0 to
3ed3bb2
Compare
bendhouseart
approved these changes
Feb 16, 2023
Collaborator
bendhouseart
left a comment
There was a problem hiding this comment.
You close out those validator issues Chris.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some existing checks assumed that the NIfTI header had been interpreted, and not simply exposed as fields. This adds
shape == dim[1:dim[0] + 1]andvoxel_sizes == pixdim[1:dim[0] + 1], which can range in length from 0 to 7.This permits us to do things like check
min(shape) > 0, which would be more inconvenient to do directly ondim.