[ENH] Introduces mdp suffix for model-derived parameters#1282
[ENH] Introduces mdp suffix for model-derived parameters#1282arokem wants to merge 41 commits intobids-standard:masterfrom
Conversation
Co-authored-by: Oscar Esteban <code@oscaresteban.es>
Co-authored-by: Oscar Esteban <code@oscaresteban.es>
Co-authored-by: Oscar Esteban <code@oscaresteban.es>
Co-authored-by: Ariel Rokem <arokem@gmail.com>
Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
|
To see the diff w.r.t. the models proposal: derivatives-model-directory...arokem:bids-specification:derivatives-param-mdp |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1282 +/- ##
==========================================
+ Coverage 88.53% 88.62% +0.09%
==========================================
Files 6 6
Lines 1055 1055
==========================================
+ Hits 934 935 +1
+ Misses 121 120 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oesteban
left a comment
There was a problem hiding this comment.
Looks like a good start.
- We want to add the new suffixes to the schema
/src/schema/objects/suffixes.yaml - We want to add the new
param-entity to/src/schema/objects/entities.yaml - We want to add the necessary metadata to specify what are the parameter labels (
param-<label>).
| Here, a *model* is defined as a process via which parameters that describe | ||
| the data are specified | ||
| (consistent with [this](https://plato.stanford.edu/entries/models-science/#DescEqua) | ||
| definition). This could include, but is not limited to things | ||
| like: |
There was a problem hiding this comment.
@arokem I have added this to the other PR, please rebase this :)
There was a problem hiding this comment.
I think we both did that at the same time :-)
This is the relevant article in the open-access Stanford Encyclopedia of Philosophy.
c1a4711 to
3e85709
Compare
…d/bids-specification into derivatives-model-directory
Following up on bids-standard#1280, this PR differentiates between model parameters and model-derived parameters. This distinction arises from considerations described in more detail in BEP16. For example, the distinction between the 6 elements of the tensor that are fit in the process of DTI, and secondary calculations of FA and MD from the eigenvalues of the tensor.
3e85709 to
916ba45
Compare
|
A thought: making the distinction between model fit parameters and model-derived parameters, might also help get rid of the troubling |
You mean |
Of course I do. Edited! |
ENH: first pass at suggestions
|
This can be closed, because it was directly tied to #1280 that was scuttled. |
Following up, and directly dependent on #1280, this PR differentiates between model parameters and model-derived parameters. This distinction arises from considerations described in more detail in BEP16. For example, the distinction between the 6 elements of the tensor that are fit in DTI, vs. secondary calculations of FA and MD from the eigenvalues of the tensor.