Conversation
franklin-feingold
left a comment
There was a problem hiding this comment.
Looks good! One very minor change was editing the title to add the prefix REL: v.
| Changelog | ||
|
|
||
| ## [Unreleased](https://github.com/bids-standard/bids-specification/tree/HEAD) | ||
| ## [1.1.2](https://github.com/bids-standard/bids-specification/tree/1.1.2) |
There was a problem hiding this comment.
| ## [1.1.2](https://github.com/bids-standard/bids-specification/tree/1.1.2) | |
| ## [Unreleased](https://github.com/bids-standard/bids-specification/tree/HEAD) | |
| ## [1.1.2](https://github.com/bids-standard/bids-specification/tree/1.1.2) |
There was a problem hiding this comment.
@franklin-feingold would this change be preserved by the automatic changelog scripts?
There was a problem hiding this comment.
Actually, I don't think this will work. @choldgraf the CI scripts will add the "unreleased" section after this is merged.
There was a problem hiding this comment.
There was a problem hiding this comment.
sounds good, +1 to merge from me then
There was a problem hiding this comment.
This change would not be preserved by the automatic changelog scripts. There will be an unreleased section as soon as another PR is merged after the release (this PR will not trigger an unreleased section generation, the next one will).
The release appears to have worked! My changelog generator scripts didn't run.
|
Only one nitpick, which is to keep an "unreleased" section :-) |
|
seems that folks are happy w/ the changes so let's see how this goes, wheeeee |
|
Though, there are two last minor things is to finish the release: create a github release and add today's date to the CHANGES.md (the date will be automatically added after the next merged PR). I created the release (https://github.com/bids-standard/bids-specification/releases/tag/v.1.1.2) and committed today's date to the CHANGES.md (5e2b113) |
|
I know that we do not have the decision rules finalized, but we should leave much more time (at least 5 working days) between proposing to make a new release and actually doing it. This allows the community to chime in and potentially prevent releasing something incorrect that we will have to support in the future. |
|
My bad - I thought we wanted to get this merged quickly to test whether the release mechanism worked |
There are no major changes in this release. It serves two purposes: