Within the MRI section, two terms are used to indicate suffixes, which I think confuses the issue.
In the "Anatomy imaging data" section, the term modality_label is used twice. First in the filename template and again in the table.
In the "Task (including resting state) imaging data" section, the term contrast_label is used twice. First in the table and again in the filename template.
These terms seem to just be one-offs, in that they're limited to their respective sections and not used regularly. Instead, within the common principles, the term suffix is used. I think we should simply replace these terms with suffix. At minimum, we should probably replace the term "modality" with something else, given that "modality" already has a definition in the specification that is much broader than the way it is used here.
There is a proposal in #508 that partially addresses this (see https://github.com/bids-standard/bids-specification/pull/508/files#r445625768 for the relevant lines), but it only deals with modality_label. Plus, as far as I can tell, even before 1.4.0, modality_label was just used in the same two spots and was never actually defined.
Within the MRI section, two terms are used to indicate suffixes, which I think confuses the issue.
In the "Anatomy imaging data" section, the term
modality_labelis used twice. First in the filename template and again in the table.In the "Task (including resting state) imaging data" section, the term
contrast_labelis used twice. First in the table and again in the filename template.These terms seem to just be one-offs, in that they're limited to their respective sections and not used regularly. Instead, within the common principles, the term
suffixis used. I think we should simply replace these terms withsuffix. At minimum, we should probably replace the term "modality" with something else, given that "modality" already has a definition in the specification that is much broader than the way it is used here.There is a proposal in #508 that partially addresses this (see https://github.com/bids-standard/bids-specification/pull/508/files#r445625768 for the relevant lines), but it only deals with
modality_label. Plus, as far as I can tell, even before 1.4.0,modality_labelwas just used in the same two spots and was never actually defined.