Skip to content

include changes of PR #84 that relate to eeg_sleep#90

Merged
robertoostenveld merged 2 commits intobids-standard:bep006_eegfrom
robertoostenveld:pull84-part3
May 26, 2018
Merged

include changes of PR #84 that relate to eeg_sleep#90
robertoostenveld merged 2 commits intobids-standard:bep006_eegfrom
robertoostenveld:pull84-part3

Conversation

@robertoostenveld
Copy link
Copy Markdown
Collaborator

@robertoostenveld robertoostenveld commented May 26, 2018

No description provided.

@robertoostenveld robertoostenveld mentioned this pull request May 26, 2018
Closed
@robertoostenveld
Copy link
Copy Markdown
Collaborator Author

robertoostenveld commented May 26, 2018

I did my previous validator check against the wrong branch. Here are the results

mac011> /Volumes/128GB/bids-validator/bin/bids-validator eeg_sleep/
	1: All rows must have the same number of columns as there are headers. (code: 22 - TSV_EQUAL_ROWS)
		./sub-01/eeg/sub-01_task-sleep_channels.tsv
			@ line: 2
			Evidence: name	type	units

	2: Not a valid JSON file. (code: 27 - JSON_INVALID)
		./sub-01/eeg/sub-01_task-sleep_eeg.json
			@ line: 8 character: 3
			Evidence:   "EOGChannelCount": 0,
		./sub-01/eeg/sub-01_task-sleep_eeg.json
			@ line: 18 character: 9
			Evidence: >>>>>>> 50c58bb094a79fd63be23e592de1d48ef2de36a9
		./sub-01/eeg/sub-01_task-sleep_eeg.json
			@ line: 10 character: 3
			Evidence: <<<<<<< HEAD
		./sub-01/eeg/sub-01_task-sleep_eeg.json
			@ line: 10 character: 5
			Evidence: <<<<<<< HEAD
		./sub-01/eeg/sub-01_task-sleep_eeg.json
			@ line: 10 character: 5
			Evidence: <<<<<<< HEAD
		./sub-01/eeg/sub-01_task-sleep_eeg.json
			@ line: 10 character: 5
		./sub-01/eeg/sub-01_task-sleep_eeg.json
			@ line: 10 character: 1
			Evidence: <<<<<<< HEAD

	3: First column of the channels file must be named 'name' (code: 71 - CHANNELS_COLUMN_NAME)
		./sub-01/eeg/sub-01_task-sleep_channels.tsv
			@ line: 1
			Evidence: <<<<<<< HEAD

	4: Second column of the channels file must be named 'type' (code: 72 - CHANNELS_COLUMN_TYPE)
		./sub-01/eeg/sub-01_task-sleep_channels.tsv
			@ line: 1 character: -1
			Evidence: <<<<<<< HEAD

	5: Third column of the channels file must be named 'units' (code: 73 - CHANNELS_COLUMN_UNITS)
		./sub-01/eeg/sub-01_task-sleep_channels.tsv
			@ line: 1 character: -1
			Evidence: <<<<<<< HEAD

        Summary:                Available Tasks:        Available Modalities: 
        39 Files, 1.62kB                                                      
        1 - Subject                                                           
        1 - Session

robertoostenveld
robertoostenveld commented May 26, 2018
View reviewed changes
eeg_sleep/sub-01/eeg/sub-01_task-sleep_channels.tsv Outdated
REF EEG uV
=======
name unit type description
C3 uV EEG
Copy link
Copy Markdown
Collaborator Author

@robertoostenveld robertoostenveld May 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the description cannot be empty without having a tab for it. I think it shoudl say n/a. Furthermore, the order of the columns is incorrect.

@robertoostenveld
Copy link
Copy Markdown
Collaborator Author

robertoostenveld commented May 26, 2018 

mac011> /Volumes/128GB/bids-validator/bin/bids-validator eeg_sleep/
This dataset appears to be BIDS compatible.
        Summary:                Available Tasks:        Available Modalities: 
        39 Files, 1.05kB        sleep                                         
        1 - Subject                                                           
        1 - Session

@robertoostenveld robertoostenveld merged commit 626f047 into bids-standard:bep006_eeg May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@robertoostenveld