Skip to content

Add travis#63

Merged
chrisgorgo merged 3 commits intobids-standard:masterfrom
jasmainak:add_travis
Mar 19, 2018
Merged

Add travis#63
chrisgorgo merged 3 commits intobids-standard:masterfrom
jasmainak:add_travis

Conversation

@jasmainak
Copy link
Copy Markdown
Collaborator

closes #5

@chrisfilo could you enable travis so we can see if this works?

@jasmainak jasmainak force-pushed the add_travis branch 2 times, most recently from 281775e to 0afa0c5 Compare March 16, 2018 00:34
@chrisgorgo
Copy link
Copy Markdown
Contributor

travis enabled - could you push a new commit to trigger a build?

.travis.yml Outdated
- "6.11.0"

install:
- npm install -g https://github.com/INCF/bids-validator.git
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix it to particular version with @

@jasmainak
Copy link
Copy Markdown
Collaborator Author

umm ... are you sure you enabled it? I pushed a commit. Nothing happened

@chrisgorgo
Copy link
Copy Markdown
Contributor

hmm it's enabled https://travis-ci.org/INCF/bids-validator, but they are experiencing some issues https://www.traviscistatus.com/incidents/kfgyk0ygvt65

@chrisgorgo
Copy link
Copy Markdown
Contributor

try now

@jasmainak
Copy link
Copy Markdown
Collaborator Author

Yayy! worked :-)

@jasmainak
Copy link
Copy Markdown
Collaborator Author

Ready for merge :-)

.travis.yml Outdated
- npm install -g https://github.com/INCF/bids-validator.git#0.25.7

script:
- for i in $(ls -d */); do bids-validator ${i%%/} --ignoreNiftiHeaders; done
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure, but I'm afraid that exit code of a for loop is the same as the last command in it - this means things failing before last test will be silenced in Travis. See https://stackoverflow.com/questions/14059342/how-to-get-the-exit-status-a-loop-in-bash

@jasmainak
Copy link
Copy Markdown
Collaborator Author

@chrisfilo comments addressed

@jasmainak
Copy link
Copy Markdown
Collaborator Author

don't ask me what I did, but it seems to work as far as I can tell :-)

@chrisgorgo
Copy link
Copy Markdown
Contributor

You're da best!

@chrisgorgo chrisgorgo merged commit 3a21712 into bids-standard:master Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some CI setup which would run bids-validator on the datasets to guarantee they are all ok

2 participants