Fixup and enhance invocation of run_tests.sh#434
Merged
rwblair merged 1 commit intobids-standard:masterfrom Apr 19, 2024
Merged
Fixup and enhance invocation of run_tests.sh#434rwblair merged 1 commit intobids-standard:masterfrom
rwblair merged 1 commit intobids-standard:masterfrom
Conversation
ATM it would complain that rc is not legit command due to all those spaces. Because no set -e used it just continues. Also made it executable and adjusted shebang to be universaly working. There should be no need to invoke directly via bash -- shebang would do that
Remi-Gau
approved these changes
Apr 15, 2024
Contributor
Remi-Gau
left a comment
There was a problem hiding this comment.
to the extend that I understand, I approve
sappelhoff
approved these changes
Apr 16, 2024
Contributor
Author
|
So the honors would go to @effigies for the last look/click of the green button! ;) |
effigies
reviewed
Apr 18, 2024
| | [ds000117](https://github.com/bids-standard/bids-examples/tree/master/ds000117) | A multi-subject, multi-modal human neuroimaging dataset of 19 subjects on a MEG visual task | anat, beh, dwi, fmap, func, meg | T1w, beh, bold, channels, coordsystem, dwi, events, headshape, magnitude1, magnitude2, meg, phasediff, scans | [link](https://openneuro.org/datasets/ds000117/) | [@RikHenson](https://github.com/RikHenson) | | ||
| | [eeg_ds003645s_hed_demo](https://github.com/bids-standard/bids-examples/tree/master/eeg_ds003645s_hed_demo) | Shows usage of Hierarchical Event Descriptor (HED) in .tsv files | eeg, beh | channels, eeg, events, participants, scans | [link](https://openneuro.org/datasets/ds003645) | [@VisLab](https://github.com/VisLab) | | ||
| | [synthetic](https://github.com/bids-standard/bids-examples/tree/master/synthetic) | A synthetic dataset | anat, beh, func | T1w, beh, bold, events, physio, scans, sessions, stim | n/a | [@effigies](https://github.com/effigies) | No newline at end of file | ||
| | [synthetic](https://github.com/bids-standard/bids-examples/tree/master/synthetic) | A synthetic dataset | anat, beh, func | T1w, beh, bold, events, physio, scans, sessions, stim | n/a | [@effigies](https://github.com/effigies) | |
Contributor
There was a problem hiding this comment.
I believe this table is generated automatically. If it will get reverted with the next regeneration, then it would be better to fix up the script.
Contributor
There was a problem hiding this comment.
yes that's true
though I cannot see what actually got changed: I suspect a whitespace so I don't think it matters much
Member
There was a problem hiding this comment.
probably "no newline" at the end of file?
bids-examples/tools/print_dataset_listing.py
Line 129 in 711be5b
And it got auto-inserted by the editor the last person touching this file was using?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATM it would complain that rc is not legit command due to all those spaces. Because no set -e used it just continues.
Also made it executable and adjusted shebang to be universaly working. There should be no need to invoke directly via bash -- shebang would do that
Script likely worked correctly anyways since there is explicit
exit $rcso if$rcremained undefined and no failed validator runs, it was justexit- clean exit?