Skip to content

Round position in pad()#1

Merged
bibinhashley merged 2 commits intobibinhashley:ImageOps.contain-function-issue-in-finding-new-sizefrom
radarhere:ImageOps.contain-function-issue-in-finding-new-size
Aug 30, 2022
Merged

Round position in pad()#1
bibinhashley merged 2 commits intobibinhashley:ImageOps.contain-function-issue-in-finding-new-sizefrom
radarhere:ImageOps.contain-function-issue-in-finding-new-size

Conversation

@radarhere
Copy link
Copy Markdown

@radarhere radarhere commented Aug 24, 2022

Two suggestions for python-pillow#6522

  1. I've added a test for your existing change. Tests are helpful to prevent us accidentally reverting your change in the future.
  2. If we're applying rounding in contain(), why not in pad() as well?

@radarhere radarhere changed the title Added test Round position in pad() Aug 24, 2022
@bibinhashley bibinhashley merged commit cf4017b into bibinhashley:ImageOps.contain-function-issue-in-finding-new-size Aug 30, 2022
@radarhere radarhere deleted the ImageOps.contain-function-issue-in-finding-new-size branch August 30, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants