Fix some load errors related to different gem versions being available#184
Merged
bibendi merged 2 commits intobibendi:masterfrom Nov 29, 2024
Merged
Fix some load errors related to different gem versions being available#184bibendi merged 2 commits intobibendi:masterfrom
bibendi merged 2 commits intobibendi:masterfrom
Conversation
- Ensure we utilize the wrapper for `load_yaml` to deal with aliases properly - Utilize `JSON::Validator.parse` as it handles MultiJson and other inconsistencies
bibendi
reviewed
Nov 28, 2024
Owner
bibendi
left a comment
There was a problem hiding this comment.
Hey Phil,
Sorry about that! Just one minor tweak, and I'll merge the changes.
Owner
|
Thank you! |
Owner
|
@oleander FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The functionality introduced via #176 is great, but it has some subtle interactions with other libraries that are causing breaking bugs for us:
psychloaded, usingYAML.load_filedirectly won't work if the config file contains aliasesMultiJsonis present,JSON::Parsermay not exist yetRelated tickets
What's inside
load_yamlto deal with aliases properlyJSON::Validator.parseas it handles MultiJson and other inconsistenciesChecklist: