Skip to content

Add validator to CI workflow#180

Merged
bibendi merged 1 commit intobibendi:masterfrom
oleander:feature/validate_all
Nov 26, 2024
Merged

Add validator to CI workflow#180
bibendi merged 1 commit intobibendi:masterfrom
oleander:feature/validate_all

Conversation

@oleander
Copy link
Contributor

  • The CI now checks all the dip.yml files in the repo against the schema to make sure they are in sync.
  • The newly introduced regexp resulted in error: Invalid regular expression: /^[\w\-\.\:\/\s]+$/u: Invalid escape.
  • Renamed the workflow to ci since it now includes schema-validate which isn't Ruby related.
  • The interaction key looks to be optional looking at some of the existing dip files.

The new action yields:

./spec/fixtures/empty/dip.yml valid
./spec/fixtures/no-schema/dip.yml valid
./spec/fixtures/missing/dip.yml valid
./spec/fixtures/cascade/dip.yml valid
./spec/fixtures/unknown_module/dip.yml valid
./spec/fixtures/overridden/dip.yml valid
./spec/fixtures/modules/dip.yml valid
./dip.yml valid
./examples/dip.yml valid

@bibendi bibendi merged commit 2069d6c into bibendi:master Nov 26, 2024
@bibendi
Copy link
Owner

bibendi commented Nov 26, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants