[Android] Custom back button image color (dotnet#24993)

kubaflo · web-flow · commit 0fb09f5ffc52 · 2025-04-22T17:31:47.000-05:00
* [Android] Custom back button image color

* Added snapshots and excluded Windows form tests

* Update CustomBackButtonShouldBeRed.png
diff --git a/src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellToolbarAppearanceTracker.cs b/src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellToolbarAppearanceTracker.cs
@@ -45,6 +45,7 @@ protected virtual void SetColors(AToolbar toolbar, IShellToolbarTracker toolbarT
 			shellToolbar.BarTextColor = title ?? ShellRenderer.DefaultTitleColor;
 			shellToolbar.BarBackground = new SolidColorBrush(background ?? ShellRenderer.DefaultBackgroundColor);
 			shellToolbar.IconColor = foreground ?? ShellRenderer.DefaultForegroundColor;
+			toolbarTracker.TintColor = foreground ?? ShellRenderer.DefaultForegroundColor;
 		}
 
 		#region IDisposable
diff --git a/src/Controls/tests/TestCases.Android.Tests/snapshots/android/CustomBackButtonShouldBeRed.png b/src/Controls/tests/TestCases.Android.Tests/snapshots/android/CustomBackButtonShouldBeRed.png
diff --git a/src/Controls/tests/TestCases.HostApp/Issues/Issue17228.xaml b/src/Controls/tests/TestCases.HostApp/Issues/Issue17228.xaml
@@ -0,0 +1,17 @@
+﻿<?xml version="1.0" encoding="utf-8" ?>
+<ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
+             xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
+             x:Class="Maui.Controls.Sample.Issues.Issue17228"
+             Shell.ForegroundColor="Red"
+             Shell.BackgroundColor="HotPink"
+             xmlns:ns="clr-namespace:Maui.Controls.Sample.Issues">
+    <Shell.BackButtonBehavior>
+        <BackButtonBehavior
+            IconOverride="groceries.png"/>
+    </Shell.BackButtonBehavior>
+    <VerticalStackLayout>
+        <Label
+            Text="Welcome to .NET MAUI!"
+            AutomationId="label"/>
+    </VerticalStackLayout>
+</ContentPage>
diff --git a/src/Controls/tests/TestCases.HostApp/Issues/Issue17228.xaml.cs b/src/Controls/tests/TestCases.HostApp/Issues/Issue17228.xaml.cs
@@ -0,0 +1,24 @@
+﻿namespace Maui.Controls.Sample.Issues
+{
+	[Issue(IssueTracker.Github, 17228, "Back button image color can't be changed", PlatformAffected.Android)]
+	public class Issue17228Shell : Shell
+	{
+		public Issue17228Shell()
+		{
+			Routing.RegisterRoute(nameof(Issue17228), typeof(Issue17228));
+			Items.Add(new ShellContent()
+			{
+				Content = new ContentPage() { Title = "Home page" }
+			});
+			GoToAsync(nameof(Issue17228));
+		}
+	}
+
+	public partial class Issue17228 : ContentPage
+	{
+		public Issue17228()
+		{
+			InitializeComponent();
+		}
+	}
+}
diff --git a/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17228.cs b/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17228.cs
@@ -0,0 +1,24 @@
+﻿#if ANDROID || IOS
+using NUnit.Framework;
+using UITest.Appium;
+using UITest.Core;
+
+namespace Microsoft.Maui.TestCases.Tests.Issues;
+
+public class Issue17228 : _IssuesUITest
+{
+	public Issue17228(TestDevice testDevice) : base(testDevice)
+	{
+	}
+
+	public override string Issue => "Back button image color can't be changed";
+
+	[Test]
+	[Category(UITestCategories.Shell)]
+	public void CustomBackButtonShouldBeRed()
+	{
+		App.WaitForElement("label");
+		VerifyScreenshot();
+	}
+}
+#endif
diff --git a/src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/CustomBackButtonShouldBeRed.png b/src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/CustomBackButtonShouldBeRed.png

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,7 @@ protected virtual void SetColors(AToolbar toolbar, IShellToolbarTracker toolbarT`
`45`	`45`	`shellToolbar.BarTextColor = title ?? ShellRenderer.DefaultTitleColor;`
`46`	`46`	`shellToolbar.BarBackground = new SolidColorBrush(background ?? ShellRenderer.DefaultBackgroundColor);`
`47`	`47`	`shellToolbar.IconColor = foreground ?? ShellRenderer.DefaultForegroundColor;`
	`48`	`+ toolbarTracker.TintColor = foreground ?? ShellRenderer.DefaultForegroundColor;`
`48`	`49`	`}`
`49`	`50`
`50`	`51`	`#region IDisposable`