Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors network connection handling and configuration management across the BGP pipeline stages, with improvements to the RPKI/RTR client implementation and build tooling.
Changes:
- Refactored connection handling to centralize configuration options in
util.DialRetryand renamedConnHandletoConnBGP - Improved RTR client session management with better locking patterns and state initialization
- Enhanced shell script robustness in the release build process
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| stages/rpki/rtr.go | Improved RTR connection retry logic, session state management, and locking patterns; removed TLS parameter from DialRetry call |
| stages/rpki/rpki.go | Replaced rtr-tls flag with generic connection flags (timeout, retry, tls, no-ipv6, insecure) |
| stages/rpki/next.go | Changed ROA cache update log level from Debug to Info |
| stages/listen.go | Refactored to use ConnBGP and reorganized flag definitions with improved descriptions |
| stages/connect.go | Refactored to use ConnBGP and moved bind address handling to DialRetry |
| pkg/util/net.go | Renamed ConnHandle to ConnBGP, enhanced DialRetry to centralize connection configuration, added keepalive and IPv6 control |
| scripts/release.sh | Fixed stderr redirection and improved error handling with safer directory operations |
| go.mod, go.sum | Updated klauspost/compress dependency from v1.18.2 to v1.18.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.