Two test methods were mutating $_REQUEST['meta-box-loader'] and using unset() for cleanup, which could cause cross-test interference if the key was set by other tests or the WordPress test bootstrap.

Changes

• Wrapped test logic in try/finally blocks with proper state restoration
• Use isset() to track whether $_REQUEST['meta-box-loader'] existed before modification
• Restore original value if key was set, or ensure it remains unset if it wasn't

Implementation

// Save the original state to restore later
$hadMetaBoxLoader = isset($_REQUEST['meta-box-loader']);
$originalMetaBoxLoader = $hadMetaBoxLoader ? $_REQUEST['meta-box-loader'] : null;

try {
    // Test logic that mutates $_REQUEST['meta-box-loader']
    $_REQUEST['meta-box-loader'] = '1';
    $result = Core::onAddOrUpdatePost($postId);
    $this->assertFalse($result);
} finally {
    // Restore original state
    if ($hadMetaBoxLoader) {
        $_REQUEST['meta-box-loader'] = $originalMetaBoxLoader;
    } else {
        unset($_REQUEST['meta-box-loader']);
    }
}

Applied to:

• onAddOrUpdatePostSkipsMetaBoxLoaderRequest
• onAddOrUpdatePostRunsWithoutMetaBoxLoader

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.