Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces "Magic Embed" (client-side integration) as a new integration method for the BeyondWords WordPress plugin, allowing content to be generated on-demand when pages are visited rather than via REST API calls. The changes refactor the player architecture to use inline script tags instead of enqueued scripts and implement a renderer-based approach for different player types.
- Adds new client-side integration method alongside the existing REST API method
- Refactors player system to use inline script tags with a renderer pattern (Javascript and AMP)
- Updates test infrastructure to work with new player implementation
Reviewed Changes
Copilot reviewed 67 out of 68 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tests/phpunit/Settings/Fields/PlayerUI/PlayerUITest.php |
Updates PlayerUI constants to use class constants instead of string literals |
tests/phpunit/Core/UninstallerTest.php |
Adds cleanup for new integration method option and forces post deletion |
tests/phpunit/Core/PlayerTest.php |
Major refactor from legacy player tests to new renderer-based player tests |
tests/phpunit/Core/Player/Renderer/JavascriptTest.php |
New tests for JavaScript player renderer |
tests/phpunit/Core/Player/Renderer/AmpTest.php |
New tests for AMP player renderer |
tests/phpunit/Core/Player/ConfigBuilderTest.php |
New tests for SDK parameter configuration builder |
tests/phpunit/Core/CoreUtilsTest.php |
Adds integration method to post meta keys list |
tests/phpunit/Core/CoreTest.php |
Updates for Magic Embed support and new audio generation logic |
tests/cypress/support/commands.js |
Updates player detection to work with new inline script approach |
| Multiple cypress test files | Updates to use new player detection commands |
| Source files | Implements Magic Embed integration, new player architecture, and related infrastructure |
Comments suppressed due to low confidence (1)
tests/phpunit/Core/Player/Renderer/AmpTest.php:1
- The test is calling static methods on 'Amp' class but the test class itself is named 'Amp', creating a naming collision. The test class should be properly named 'AmpTest' and call the actual renderer class methods.
<?php
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.