Asset page filtering#734
Merged
cart merged 3 commits intobevyengine:mainfrom Aug 23, 2023
d-bucur:main
Merged
Conversation
Grid style cards still leave empty spaces though
Contributor
Author
|
Nevermind, setting display:none on grid elements does hide them properly, I was just doing it on the wrong element. So no need for big changes. Will update with images soon. |
Correctly hides cards in grid and empty sections
Contributor
Author
|
And it's ready. Terms are separated by space and put in AND. Feedback welcome. Screencast.from.22-08-2023.22.44.09.webm |
Member
|
(I removed the submodule that you added) |
Contributor
Author
|
Thanks! Didn't notice that submodule slip by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP for Issue #450
I created a search bar that can filter cards in JS. The problem is that the cards are in a
gridand when settingdisplay:noneit will leave around empty spaces. The only way I see to do it properly would be to change the display of the cards toflex-rowinstead ofgrid(which I think makes more sense for this layout anyway), but that requires quite a bit of work making sure everything is responsive and that there are no regressions.Result when searching for "MIT"
Any thoughts on this?