Skip to content

Asset changed release notes#2031

Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom
alice-i-cecile:asset-changed-notes
Mar 28, 2025
Merged

Asset changed release notes#2031
alice-i-cecile merged 2 commits intobevyengine:mainfrom
alice-i-cecile:asset-changed-notes

Conversation

@alice-i-cecile
Copy link
Copy Markdown
Member

@alice-i-cecile alice-i-cecile commented Mar 28, 2025

Fixes #1975.

Copy link
Copy Markdown
Member

@tychedelia tychedelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great. My only thought is that we might add that this is a kind of table scan (like Changed<T>) and incurs a bit of performance penalty. But that's also documented already in the code itself.

@alice-i-cecile
Copy link
Copy Markdown
Member Author

Mhmm, I think that that's the sort of detail that I'm happy to send users to the actual docs for. It's also going to be faster than any alternative approach, so I don't think the perf caveat is very helpful.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 28, 2025
Merged via the queue into bevyengine:main with commit f01d0d3 Mar 28, 2025
10 checks passed
@alice-i-cecile alice-i-cecile deleted the asset-changed-notes branch March 28, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write release notes for PR #16810: Add AssetChanged query filter

2 participants