Gamepads as entities release notes#1762
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Nov 3, 2024
Merged
Conversation
MiniaczQ
approved these changes
Nov 3, 2024
Contributor
MiniaczQ
left a comment
There was a problem hiding this comment.
Looks good overall, few smaller one bigger nit
release-content/0.15/release-notes/12770_Implement_gamepads_as_entities.md
Outdated
Show resolved
Hide resolved
release-content/0.15/release-notes/12770_Implement_gamepads_as_entities.md
Outdated
Show resolved
Hide resolved
release-content/0.15/release-notes/12770_Implement_gamepads_as_entities.md
Outdated
Show resolved
Hide resolved
release-content/0.15/release-notes/12770_Implement_gamepads_as_entities.md
Outdated
Show resolved
Hide resolved
Comment on lines
+68
to
+69
| [`Gamepad`]: https://docs.rs/bevy/0.15.0-rc.2/bevy/input/gamepad/struct.Gamepad.html | ||
| [`GamepadSettings`]: https://docs.rs/bevy/0.15.0-rc.2/bevy/input/gamepad/struct.GamepadSettings.html |
Contributor
There was a problem hiding this comment.
I need to add this to fallible param notes
Co-authored-by: MiniaczQ <xnetroidpl@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1700.
This PR directly adapts the example by @s-puig in bevyengine/bevy#12770 to demonstrate the new API, and the ergonomic improvements over the previous one. Thanks!