Skip to content

Realese Note for #15361: Implement volumetric fog support for both po…#1745

Merged
cart merged 3 commits intobevyengine:mainfrom
Soulghost:rn/volumetric_fog_15361
Nov 15, 2024
Merged

Realese Note for #15361: Implement volumetric fog support for both po…#1745
cart merged 3 commits intobevyengine:mainfrom
Soulghost:rn/volumetric_fog_15361

Conversation

@Soulghost
Copy link
Copy Markdown
Contributor

Fixes #1702

Copy link
Copy Markdown
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small edits, but more importantly I'd really like to have a screenshot for this :) This is one of our few shiny rendering features this release.

@Soulghost
Copy link
Copy Markdown
Contributor Author

Hi @alice-i-cecile , I would like to ask for advice on storing the updated volumetric fog screenshot. Should I link to the existing URL and wait for it to update automatically by the GitHub action, or should I place the image elsewhere?

@alice-i-cecile
Copy link
Copy Markdown
Member

This should be stored in the repo: check out the 0.14 release notes for where and how this is done. We should also remove the instruction text from the image for showcase purposes.

@Soulghost
Copy link
Copy Markdown
Contributor Author

I have checked the release notes in 0.14 that contain images, both of them use a image path like this:

![](filmic_color_grading.jpg)

However, the filmic_color_grading.jpg is actually located at content/news/2024-07-04-bevy-0.14/filmic_color_grading.jpg, not in the same directory as the markdown file. I haven't figure out how the markdown file links to the associated image.

Below is the screenshot without help text. Could you guide me on how to properly link it to the markdown file? Thank you!
volumetric_fog_with_three_lights

@mweatherley
Copy link
Copy Markdown
Contributor

mweatherley commented Nov 7, 2024

Could you guide me on how to properly link it to the markdown file? Thank you!

Now that there is a stub for the actual release notes page, what you'll want to do is merge the main branch into your PR branch and put the image into the content/news/2024-??-??-bevy-0.15 folder. When referencing it in markdown, it will just be my-image.png or whatever, where that's the name that you gave it.

@cart cart force-pushed the rn/volumetric_fog_15361 branch from 833bf4d to a70dc7c Compare November 15, 2024 20:56
Copy link
Copy Markdown
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the image and rebased. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write release notes for PR #15361: Implement volumetric fog support for both point lights and spotlights

4 participants