Asset validation#163
Merged
cart merged 3 commits intobevyengine:masterfrom May 30, 2021
mockersf:asset-validation
Merged
Conversation
35 tasks
Member
|
Looks good to me! I'm assuming the plan is to check out the bevy-website repo in the awesome-bevy repo's CI, then run the validator? At least for now that seems preferable to duplicated asset code in the awesome-bevy repo, moving all asset code into the awesome-bevy repo, or creating an new repo. |
Member
Author
|
Once merged, this will work: I'll use that to run the validation from awesome-bevy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a bin for asset validation. Current output is:
Output is not pretty... but it looks OK for me
And added image support
Current accepted toml:
The description is made mandatory on the validation step and not at parsing time because a few assets currently are missing it, this should be changed once those assets are fixed.
Validation will also fail on an unknown field.