Fix shader_material_glsl example after #9254#9311
Merged
superdump merged 1 commit intobevyengine:mainfrom Jul 31, 2023
Merged
Conversation
robtfm
approved these changes
Jul 30, 2023
Contributor
robtfm
left a comment
There was a problem hiding this comment.
shame we have to reintroduce the shader def in the mesh pipeline but hopefully it'll be temporary.
mockersf
approved these changes
Jul 30, 2023
fe41929 to
0c03ae8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
PER_OBJECT_BUFFER_BATCH_SIZEshader def through the defaultMeshPipelinespecialization.custom_material.vertshader to access the mesh binding.Changelog
PER_OBJECT_BUFFER_BATCH_SIZEshader def through the defaultMeshPipelinespecialization to use in custom shaders not using bevy_pbr::mesh_bindings that still want to use the mesh binding in some way.