make glsl and spirv support optional#8491
Merged
cart merged 3 commits intobevyengine:mainfrom Apr 25, 2023
Merged
Conversation
alice-i-cecile
approved these changes
Apr 25, 2023
Contributor
|
You added a new feature but didn't add a description for it. Please update the root Cargo.toml file. |
IceSentry
approved these changes
Apr 25, 2023
tim-blackbird
approved these changes
Apr 25, 2023
cart
approved these changes
Apr 25, 2023
Member
cart
left a comment
There was a problem hiding this comment.
Thats a big enough win that its hard to ignore. Good call!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
spirvandglslshader format support optional. They are not needed for Bevy shaders.msl), this reduces the total build time by 2 to 5 seconds, improvement should be even better with less coresThere is a big reduction in compile time for
naga, and small improvements onwgpuandbevy_renderThis PR with optional shader formats enabled timings:

This PR:

Migration Guide
spirv, enable theshader_format_spirvfeatureglsl, enable theshader_format_glslfeature