Revive iter_entities() when you only have immutable World access ❤️🩹 #22864
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Feb 8, 2026
Merged
Conversation
alice-i-cecile
approved these changes
Feb 8, 2026
ElliottjPierce
approved these changes
Feb 8, 2026
Contributor
ElliottjPierce
left a comment
There was a problem hiding this comment.
Looks good to me! And yeah, this has to be on the World. The Entities type doesn't have strong access to what entities are not freed.
Trashtalk217
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
iter_entities()is back as an ergonomic way to non-fallibly iterate through all the entities when you only have immutableWorldaccess.iter_entities()onEntitiesbecause it seems deliberate from conversation in Add anEntities::iter()method to iterate over all entities when you only have&World#6228 … although I could be convinced otherwise if the conversation is outdated.Testing