Objective

Fixes the following log spam (and wrong sync behavior) introduced by #22766:

ERROR bevy_pbr::cluster: Clustered light or decal 5v0 had no assigned index!

Solution

The components here are named in an interesting way. We have 3 components:

• EnvironmentMapLight
• GeneratedEnvironmentMapLight
• RenderEnvironmentMap

When I added the SyncComponent impl I pattern matched on the upper two names, and assumed that EnvironmentMapLight was the main world component and GeneratedEnvironmentMapLight was in the render world.

Actually GeneratedEnvironmentMapLight is a specific way to generate an EnvironmentMapLight, and the render world entity is called RenderEnvironmentMap. Fixing the SyncComponent impl to reflect that fixes the issue.

I still feel like there are other issues after this fix:

• GeneratedEnvironmentMapLight could really use a better name (GenerateEnvironmentMapLight? RuntimeEnvironmentMapLight?), and better docs.
• I think it's still missing some syncing logic, as far as I can tell nothing handles the generated EnvironmentMapLight if a GeneratedEnvironmentMapLight is updated or deleted? I didn't do a deep dive so I might have missed something.

Testing

Tested with the light_probe_blending and reflection_probes examples.