Skip to content

Add an app label to ExtractPlugin#22855

Draft
atlv24 wants to merge 3 commits intobevyengine:mainfrom
atlv24:ad/extract-label
Draft

Add an app label to ExtractPlugin#22855
atlv24 wants to merge 3 commits intobevyengine:mainfrom
atlv24:ad/extract-label

Conversation

@atlv24
Copy link
Copy Markdown
Contributor

@atlv24 atlv24 commented Feb 7, 2026

Objective

Solution

  • Make ExtractPlugin take an app label so it can be used on other sub apps in the future

Testing

  • 3d_scene runs

@atlv24 atlv24 marked this pull request as draft February 7, 2026 16:22
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Feb 8, 2026
@alice-i-cecile
Copy link
Copy Markdown
Member

@atlv24 what's needed to take this out of draft?

@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed C-Code-Quality A section of code that is hard to understand or change labels Feb 8, 2026
@atlv24
Copy link
Copy Markdown
Contributor Author

atlv24 commented Feb 8, 2026

I have some local changes im working on to make this actually work; the change will have to be a tad more invasive to work. We need to key the Extract impls by the sub app AppLabel @alice-i-cecile

@cart cart added this to Rendering Feb 12, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged

Projects

Status: Needs SME Triage
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants