Merged
Conversation
IQuick143
reviewed
Jan 30, 2026
Comment on lines
+277
to
+279
| load_shader_library!(app, "maths.wgsl"); | ||
| load_shader_library!(app, "color_operations.wgsl"); | ||
| load_shader_library!(app, "bindless.wgsl"); |
Contributor
There was a problem hiding this comment.
I can't comment on whether this move is valid, bc I don't have the expertise, but otherwise everything checks out.
Contributor
Author
There was a problem hiding this comment.
yeah, if you look at how any other rendering plugin does it they have it in build. It just needs to be after Shader asset init really, and i dont have to move it tbh i just thought it made more sense there
IQuick143
approved these changes
Jan 30, 2026
mockersf
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing
Note: reviewing commit by commit is easier, when a large block moves its just copy paste