Skip to content

RenderResources refactor#22737

Merged
mockersf merged 4 commits intobevyengine:mainfrom
atlv24:ad/render-resources-refactor
Jan 30, 2026
Merged

RenderResources refactor#22737
mockersf merged 4 commits intobevyengine:mainfrom
atlv24:ad/render-resources-refactor

Conversation

@atlv24
Copy link
Copy Markdown
Contributor

@atlv24 atlv24 commented Jan 30, 2026

Objective

Solution

  • Make it take main and render worlds as input
  • Use subapp destructure to get mutable access to both worlds simultaneously
  • Move it to live next to the struct def
  • Document
  • Also move shader library loads up to build because theres no reason for them to be in finish

Testing

  • 3d_scene runs

Note: reviewing commit by commit is easier, when a large block moves its just copy paste

@atlv24 atlv24 added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 30, 2026
Comment on lines +277 to +279
load_shader_library!(app, "maths.wgsl");
load_shader_library!(app, "color_operations.wgsl");
load_shader_library!(app, "bindless.wgsl");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on whether this move is valid, bc I don't have the expertise, but otherwise everything checks out.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, if you look at how any other rendering plugin does it they have it in build. It just needs to be after Shader asset init really, and i dont have to move it tbh i just thought it made more sense there

@IQuick143 IQuick143 added C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Jan 30, 2026
@mockersf mockersf added this pull request to the merge queue Jan 30, 2026
Merged via the queue into bevyengine:main with commit 44dee24 Jan 30, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants