Cleaner macros utilizing syn::Member v2#21678
Cleaner macros utilizing syn::Member v2#21678alice-i-cecile merged 17 commits intobevyengine:mainfrom
Conversation
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
1 similar comment
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
|
no idea whats causing the changes in graphical output |
Trashtalk217
left a comment
There was a problem hiding this comment.
This is a good improvement. I do wonder if shape.rs (in macro_utils) could maybe be renamed / be rehomed to a different file, because there's very little reason for it to exist.
|
@Bleachfuel ping me when CI is green and I'll get this in (finally 😅). Sorry for the headaches! |
|
@alice-i-cecile I think i fixed everything 😅 As a follow up i want to find a better alternative to the members and fields |
Objective
Some macros were handling Idents and indexes as seperate things, we can use syn::Member to make this more readable and nicer.
revive of #18199