Disable depth downsampling on GL/WebGL with downlevel flag#20304
Open
alextechcc wants to merge 1 commit intobevyengine:mainfrom
Open
Disable depth downsampling on GL/WebGL with downlevel flag#20304alextechcc wants to merge 1 commit intobevyengine:mainfrom
alextechcc wants to merge 1 commit intobevyengine:mainfrom
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
IceSentry
approved these changes
Jul 28, 2025
Author
|
I want to ensure that the other affected platform - webgl - wouldn't be downgraded by this flag. I believe that it's likely all webgl platforms fall back to cpu preprocessing. |
3e7805a to
b14ed2b
Compare
Author
|
Not exactly sure why all the tests are failing (toolchain changed?), but I think it's safe to merge. WebGL2 doesn't support compute shaders so this is already set, and the only other backend that sets this flag is opengl which does not support the current way culling is implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing