Deprecate iter_entities and iter_entities_mut#20260
Merged
alice-i-cecile merged 12 commits intobevyengine:mainfrom Jul 23, 2025
Merged
Deprecate iter_entities and iter_entities_mut#20260alice-i-cecile merged 12 commits intobevyengine:mainfrom
iter_entities and iter_entities_mut#20260alice-i-cecile merged 12 commits intobevyengine:mainfrom
Conversation
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
alice-i-cecile
approved these changes
Jul 23, 2025
Carter0
reviewed
Jul 23, 2025
Carter0
reviewed
Jul 23, 2025
Co-authored-by: Carter Weinberg <weinbergcarter@gmail.com>
Co-authored-by: Carter Weinberg <weinbergcarter@gmail.com>
Carter0
approved these changes
Jul 23, 2025
Member
|
Waiting on a quick test to ensure the workaround in the migration guide keeps working, then I'll be comfortable merging this. |
alice-i-cecile
approved these changes
Jul 23, 2025
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Both
iter_entities()anditer_entities_mutare awkward functions as they both return all entities, which is something you (should) rarely want.Solution
Deprecate both functions and substitute them where they are used.
Testing
Not necessary.