Fix glTF importer wrongly ignoring sampler filters#19118
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom May 26, 2025
Merged
Fix glTF importer wrongly ignoring sampler filters#19118alice-i-cecile merged 1 commit intobevyengine:mainfrom
alice-i-cecile merged 1 commit intobevyengine:mainfrom
Conversation
Contributor
Author
|
I'm changing the milestone to 0.17 as the bug shouldn't be present in 0.16 - #17875 was merged post-0.16. |
axlitEels
approved these changes
May 8, 2025
Contributor
axlitEels
left a comment
There was a problem hiding this comment.
I probably should review as the author of this bug. Thanks for quick investigation!
ThierryBerger
approved these changes
May 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix #19114.
Solution
#17875 changed the glTF importer to make sure that sampler filters are linear when anisotropic filtering is enabled - this is required by
wgpu. But the condition was mistakenly inverted, so it forces the filtering to linear when anisotropic filtering is not enabled.Testing