Add missing system ordering constraint to prepare_lights#18308
Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom Mar 15, 2025
Merged
Add missing system ordering constraint to prepare_lights#18308alice-i-cecile merged 4 commits intobevyengine:mainfrom
alice-i-cecile merged 4 commits intobevyengine:mainfrom
Conversation
hukasu
approved these changes
Mar 14, 2025
Contributor
Author
|
Need to also remove the prepare_assets constraint, no longer needed. |
mockersf
reviewed
Mar 15, 2025
mockersf
approved these changes
Mar 15, 2025
mockersf
reviewed
Mar 15, 2025
Contributor
Author
|
I have literately no clue what's going on with the imports, but I added them to the files missing them and it compiles now. |
Contributor
Author
|
Ok so the way rust works, adding Not really what I intended, but oh well. |
IceSentry
approved these changes
Mar 15, 2025
Contributor
|
confirmed that the errors are no longer logged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #18094.