Skip to content

Add missing system ordering constraint to prepare_lights#18308

Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom
JMS55:invalid_view_query_fix
Mar 15, 2025
Merged

Add missing system ordering constraint to prepare_lights#18308
alice-i-cecile merged 4 commits intobevyengine:mainfrom
JMS55:invalid_view_query_fix

Conversation

@JMS55
Copy link
Copy Markdown
Contributor

@JMS55 JMS55 commented Mar 14, 2025

Fix #18094.

@JMS55 JMS55 added the A-Rendering Drawing game state to the screen label Mar 14, 2025
@JMS55 JMS55 added this to the 0.16 milestone Mar 14, 2025
@JMS55
Copy link
Copy Markdown
Contributor Author

JMS55 commented Mar 14, 2025

Need to also remove the prepare_assets constraint, no longer needed.

@JMS55 JMS55 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 15, 2025
@alice-i-cecile alice-i-cecile added the C-Bug An unexpected or incorrect behavior label Mar 15, 2025
@JMS55
Copy link
Copy Markdown
Contributor Author

JMS55 commented Mar 15, 2025

I have literately no clue what's going on with the imports, but I added them to the files missing them and it compiles now.

@JMS55
Copy link
Copy Markdown
Contributor Author

JMS55 commented Mar 15, 2025

Ok so the way rust works, adding use foo to lib.rs means any sub-module of bevy_pbr (e.g. bevy_pbr::render::mesh) can access foo by doing use crate::foo or use crate::*.

Not really what I intended, but oh well.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 15, 2025
Merged via the queue into bevyengine:main with commit 195a74a Mar 15, 2025
31 checks passed
@hukasu
Copy link
Copy Markdown
Contributor

hukasu commented Mar 15, 2025

confirmed that the errors are no longer logged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Error logged when running 3d examples

5 participants