Update log_layers_ecs example for children macro#18293
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Jun 30, 2025
Merged
Update log_layers_ecs example for children macro#18293alice-i-cecile merged 2 commits intobevyengine:mainfrom
alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
Contributor
Author
|
The more I look at trying to make the outer spawniter work, the more I feel like the submitted changes are the right scope, especially since we reverted the spawniter changes in other related PRs. I think this is ready for straightforward review. Editing PR description to remove the extra context. |
AlephCubed
approved these changes
Mar 26, 2025
chescock
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Contributes to #18238
Updates the
log_layers_ecs, example to use thechildren!macro.Note that I did not use a macro, nor
Children::spawnfor the outer layer. Since theEventReaderis borrowed mutably, any.mapI did onevents.read()was going to have the reference outlive the function body. I believe this scope of change is correct for the PR.Solution
Updates examples to use the Improved Spawning API merged in #17521
Testing
--features wayland.Showcase
n/a
Migration Guide
n/a