Update shader_prepass, testbed_2d, and first_person_view_model examples to use children! macro#18270
Conversation
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
Hm, when clicking the link here I see a comparison which reports 17 screenshots in the unchanged category. Is there something I'm missing here? |
|
Yeah that's really odd. @mockersf, do you know what's up with that? |
234fdfa to
bf367c5
Compare
| StateScoped(super::Scene::Text), | ||
| children![ | ||
| ( | ||
| TextSpan::new(format!("{}, {}\n", anchor.x, anchor.y)), |
There was a problem hiding this comment.
I resolved a merge conflict on these lines, I believe this line was the only delta but worth re-reviewing with a close eye.
Objective
Contributes to #18238
Updates the
shader_prepass,testbed_2dandfirst_person_view_modelexamples to use thechildren!macro. I wanted to keep the PR small but chose to do 3 examples since they were all limited in scopeSolution
Updates examples to use the Improved Spawning API merged in #17521
Testing
--features wayland.Showcase
n/a
Migration Guide
n/a