Skip to content

Fix dds feature enabling bevy_gltf#17888

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
rparrett:dds-gltf
Feb 17, 2025
Merged

Fix dds feature enabling bevy_gltf#17888
alice-i-cecile merged 1 commit intobevyengine:mainfrom
rparrett:dds-gltf

Conversation

@rparrett
Copy link
Copy Markdown
Contributor

@rparrett rparrett commented Feb 17, 2025

Objective

Fixes #17022

Solution

Only enable bevy_gltf/dds if bevy_gltf is already enabled.

Testing

Tested with empty project

[dependencies]
bevy = { version = "0.16.0-dev", path = "../bevy", default-features = false, features = [
    "dds",
] }

Before

 cargo tree --depth 1 -i bevy_gltf
bevy_gltf v0.16.0-dev (/Users/robparrett/src/bevy/crates/bevy_gltf)
└── bevy_internal v0.16.0-dev (/Users/robparrett/src/bevy/crates/bevy_internal)

After

 cargo tree --depth 1 -i bevy_gltf
warning: nothing to print.

To find dependencies that require specific target platforms, try to use option `--target all` first, and then narrow your search scope accordingly.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-glTF Related to the glTF 3D scene/model format P-Compile-Failure A failure to compile Bevy apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 17, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 17, 2025
Merged via the queue into bevyengine:main with commit 4045b91 Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees

No one assigned

Labels

A-glTF Related to the glTF 3D scene/model format C-Bug An unexpected or incorrect behavior P-Compile-Failure A failure to compile Bevy apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enabling DDS feature leds to GLTF also becoming enabled

2 participants

@rparrett @alice-i-cecile