Skip to content

Fix panic in custom_render_phase example#17866

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
rparrett:fix-custom-render-phase
Feb 16, 2025
Merged

Fix panic in custom_render_phase example#17866
alice-i-cecile merged 1 commit intobevyengine:mainfrom
rparrett:fix-custom-render-phase

Conversation

@rparrett
Copy link
Copy Markdown
Contributor

@rparrett rparrett commented Feb 15, 2025 •
edited
Loading

Objective

Fix panic in custom_render_phase.

This example was broken by #17764, but that breakage evolved into a panic after #17849. This new panic seems to illustrate the problem in a pretty straightforward way.

2025-02-15T00:44:11.833622Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "macOS 15.3 Sequoia", kernel: "24.3.0", cpu: "Apple M4 Max", core_count: "16", memory: "64.0 GiB" }    
2025-02-15T00:44:11.908328Z  INFO bevy_render::renderer: AdapterInfo { name: "Apple M4 Max", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }
2025-02-15T00:44:12.314930Z  INFO bevy_winit::system: Creating new window App (0v1)
thread 'Compute Task Pool (1)' panicked at /Users/me/src/bevy/crates/bevy_ecs/src/system/function_system.rs:216:28:
bevy_render::batching::gpu_preprocessing::batch_and_prepare_sorted_render_phase<custom_render_phase::Stencil3d, custom_render_phase::StencilPipeline> could not access system parameter ResMut<PhaseBatchedInstanceBuffers<Stencil3d, MeshUniform>>

Solution

Add a SortedRenderPhasePlugin for the custom phase.

Testing

cargo run --example custom_render_phase

@rparrett rparrett changed the title Fix panic in custom_render_phase example Fix panic in custom_render_phase example Feb 15, 2025
@rparrett rparrett added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples P-Crash A sudden unexpected crash S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Feb 15, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 16, 2025
Merged via the queue into bevyengine:main with commit e186c7c Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@pcwalton pcwalton Awaiting requested review from pcwalton

+1 more reviewer

@IceSentry IceSentry IceSentry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples D-Straightforward Simple bug fixes and API improvements, docs, test and examples P-Crash A sudden unexpected crash S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

No open projects
Rendering (Old)
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rparrett @alice-i-cecile @IceSentry