Skip to content

Replace BufferVec<PreprocessWorkItem> with RawBufferVec<PreprocessWorkItem>.#17862

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
pcwalton:work-item-raw-buffer-vec
Feb 16, 2025
Merged

Replace BufferVec<PreprocessWorkItem> with RawBufferVec<PreprocessWorkItem>.#17862
alice-i-cecile merged 1 commit intobevyengine:mainfrom
pcwalton:work-item-raw-buffer-vec

Conversation

@pcwalton
Copy link
Copy Markdown
Contributor

@pcwalton pcwalton commented Feb 14, 2025

Appending to these vectors is performance-critical in batch_and_prepare_binned_render_phase, so RawBufferVec, which doesn't have the overhead of encase, is more appropriate.

@pcwalton
Replace BufferVec<PreprocessWorkItem> with
93efed2 
`RawBufferVec<PreprocessWorkItem>`.

Appending to these vectors is performance-critical in
`batch_and_prepare_binned_render_phase`, so `RawBufferVec`, which
doesn't have the overhead of `encase`, is more appropriate.
@pcwalton pcwalton added D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Performance A change motivated by improving speed, memory usage or compile times labels Feb 14, 2025
@tychedelia tychedelia added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 14, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 16, 2025
Merged via the queue into bevyengine:main with commit 137878a Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IceSentry IceSentry Awaiting requested review from IceSentry

2 more reviewers

@kristoff3r kristoff3r kristoff3r approved these changes

@tychedelia tychedelia tychedelia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

No open projects
Rendering (Old)
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pcwalton @kristoff3r @tychedelia @alice-i-cecile